Checkout test refactor: Successful Jan 2 2018

https://checkout-test-refactor.staging.clippings.com

Svetlozar Stoyanov
By Svetlozar Stoyanov

What is this about?

Minor refactoring for better understanding and readability.
Extracting methods will be done in another PR when time allows.

Checklist

  • [x] Add comments in ::test_checkout_shipping_and_payment
  • [x] Combine multiple lines Ecommerce test class.
  • [x] Assigned people to review

Staging to review

https://checkout-test-refactor.staging.clippings.com

Creating database staging_checkout-test-refactor
Warning: Using a password on the command line interface can be insecure.
Populating database checkout-test-refactor
Warning: Using a password on the command line interface can be insecure.
 129MiB 0:00:30 [4.24MiB/s] [>                                 ]  1% ETA 0:30:31
 219MiB 0:01:00 [3.03MiB/s] [>                                 ]  2% ETA 0:35:41
 311MiB 0:01:30 [ 3.1MiB/s] [>                                 ]  3% ETA 0:37:14
 410MiB 0:02:01 [3.18MiB/s] [>                                 ]  5% ETA 0:37:33
 502MiB 0:02:30 [3.17MiB/s] [=>                                ]  6% ETA 0:37:35
 596MiB 0:03:00 [3.11MiB/s] [=>                                ]  7% ETA 0:37:32
 687MiB 0:03:30 [3.06MiB/s] [=>                                ]  8% ETA 0:37:29
 783MiB 0:04:00 [3.18MiB/s] [==>                               ]  9% ETA 0:37:08
 881MiB 0:04:30 [3.26MiB/s] [==>                               ] 10% ETA 0:36:38
1000MiB 0:05:00 [3.97MiB/s] [===>                              ] 12% ETA 0:35:15
 1.1GiB 0:05:30 [4.32MiB/s] [===>                              ] 14% ETA 0:33:43
1.28GiB 0:06:00 [5.95MiB/s] [====>                             ] 16% ETA 0:30:57
1.36GiB 0:06:30 [2.89MiB/s] [====>                             ] 17% ETA 0:31:03
1.43GiB 0:07:00 [2.32MiB/s] [=====>                            ] 18% ETA 0:31:29
 1.5GiB 0:07:30 [2.28MiB/s] [=====>                            ] 19% ETA 0:31:55
1.57GiB 0:08:00 [2.31MiB/s] [=====>                            ] 19% ETA 0:32:13
1.63GiB 0:08:30 [2.36MiB/s] [=====>                            ] 20% ETA 0:32:26
 1.7GiB 0:09:00 [ 2.3MiB/s] [======>                           ] 21% ETA 0:32:38
1.77GiB 0:09:30 [2.34MiB/s] [======>                           ] 22% ETA 0:32:43
1.83GiB 0:10:00 [2.07MiB/s] [======>                           ] 23% ETA 0:32:58
1.89GiB 0:10:30 [2.14MiB/s] [=======>                          ] 24% ETA 0:33:09
1.96GiB 0:11:00 [2.14MiB/s] [=======>                          ] 24% ETA 0:33:15
2.02GiB 0:11:30 [2.09MiB/s] [=======>                          ] 25% ETA 0:33:20
2.08GiB 0:12:00 [2.12MiB/s] [=======>                          ] 26% ETA 0:33:24
2.14GiB 0:12:31 [2.16MiB/s] [========>                         ] 27% ETA 0:33:25
 2.2GiB 0:13:00 [2.15MiB/s] [========>                         ] 28% ETA 0:33:23
2.27GiB 0:13:30 [ 2.1MiB/s] [========>                         ] 28% ETA 0:33:21
2.33GiB 0:14:00 [2.07MiB/s] [========>                         ] 29% ETA 0:33:19
2.39GiB 0:14:30 [2.13MiB/s] [=========>                        ] 30% ETA 0:33:13
2.45GiB 0:15:00 [1.98MiB/s] [=========>                        ] 31% ETA 0:33:13
2.51GiB 0:15:30 [1.99MiB/s] [=========>                        ] 31% ETA 0:33:10
2.57GiB 0:16:00 [1.98MiB/s] [=========>                        ] 32% ETA 0:33:04
2.63GiB 0:16:30 [2.09MiB/s] [==========>                       ] 33% ETA 0:32:57
2.69GiB 0:17:00 [2.07MiB/s] [==========>                       ] 34% ETA 0:32:47
2.75GiB 0:17:30 [2.01MiB/s] [==========>                       ] 34% ETA 0:32:38
2.81GiB 0:18:00 [2.05MiB/s] [==========>                       ] 35% ETA 0:32:29
2.86GiB 0:18:30 [2.06MiB/s] [===========>                      ] 36% ETA 0:32:18
2.93GiB 0:19:00 [2.26MiB/s] [===========>                      ] 37% ETA 0:31:58
2.99GiB 0:19:30 [2.04MiB/s] [===========>                      ] 38% ETA 0:31:47
3.06GiB 0:20:00 [2.25MiB/s] [===========>                      ] 38% ETA 0:31:28
3.12GiB 0:20:30 [2.26MiB/s] [============>                     ] 39% ETA 0:31:07
3.19GiB 0:21:00 [2.29MiB/s] [============>                     ] 40% ETA 0:30:45
3.26GiB 0:21:31 [2.24MiB/s] [============>                     ] 41% ETA 0:30:26
3.32GiB 0:22:01 [2.04MiB/s] [=============>                    ] 42% ETA 0:30:11
3.38GiB 0:22:30 [   2MiB/s] [=============>                    ] 42% ETA 0:29:57
3.43GiB 0:23:00 [2.03MiB/s] [=============>                    ] 43% ETA 0:29:41
3.49GiB 0:23:30 [2.03MiB/s] [=============>                    ] 44% ETA 0:29:25
3.55GiB 0:24:00 [   2MiB/s] [==============>                   ] 45% ETA 0:29:09
3.62GiB 0:24:30 [2.15MiB/s] [==============>                   ] 45% ETA 0:28:49
3.67GiB 0:25:00 [   2MiB/s] [==============>                   ] 46% ETA 0:28:32
3.74GiB 0:25:31 [2.03MiB/s] [==============>                   ] 47% ETA 0:28:14
3.79GiB 0:26:01 [2.04MiB/s] [===============>                  ] 48% ETA 0:27:55
3.85GiB 0:26:30 [2.09MiB/s] [===============>                  ] 48% ETA 0:27:35
3.91GiB 0:27:00 [2.06MiB/s] [===============>                  ] 49% ETA 0:27:16
3.97GiB 0:27:30 [1.99MiB/s] [================>                 ] 50% ETA 0:26:58
4.04GiB 0:28:00 [2.12MiB/s] [================>                 ] 51% ETA 0:26:35
 4.1GiB 0:28:30 [2.06MiB/s] [================>                 ] 52% ETA 0:26:15
4.16GiB 0:29:00 [2.13MiB/s] [================>                 ] 52% ETA 0:25:51
4.22GiB 0:29:30 [2.13MiB/s] [=================>                ] 53% ETA 0:25:30
4.28GiB 0:30:00 [2.13MiB/s] [=================>                ] 54% ETA 0:25:06
4.34GiB 0:30:30 [2.09MiB/s] [=================>                ] 55% ETA 0:24:44
 4.4GiB 0:31:00 [2.08MiB/s] [=================>                ] 55% ETA 0:24:22
4.47GiB 0:31:30 [2.16MiB/s] [==================>               ] 56% ETA 0:23:57
4.53GiB 0:32:00 [2.18MiB/s] [==================>               ] 57% ETA 0:23:33
 4.6GiB 0:32:30 [2.24MiB/s] [==================>               ] 58% ETA 0:23:07
4.66GiB 0:33:00 [2.01MiB/s] [===================>              ] 59% ETA 0:22:45
4.72GiB 0:33:30 [2.04MiB/s] [===================>              ] 59% ETA 0:22:23
4.78GiB 0:34:00 [2.03MiB/s] [===================>              ] 60% ETA 0:22:00
4.83GiB 0:34:30 [2.01MiB/s] [===================>              ] 61% ETA 0:21:39
4.89GiB 0:35:01 [1.96MiB/s] [====================>             ] 62% ETA 0:21:16
4.95GiB 0:35:30 [2.03MiB/s] [====================>             ] 62% ETA 0:20:54
5.01GiB 0:36:00 [2.01MiB/s] [====================>             ] 63% ETA 0:20:31
5.07GiB 0:36:30 [2.01MiB/s] [====================>             ] 64% ETA 0:20:08
5.13GiB 0:37:00 [   2MiB/s] [=====================>            ] 65% ETA 0:19:46
5.19GiB 0:37:30 [1.97MiB/s] [=====================>            ] 65% ETA 0:19:23
5.24GiB 0:38:00 [1.73MiB/s] [=====================>            ] 66% ETA 0:19:05
5.32GiB 0:38:30 [ 2.7MiB/s] [=====================>            ] 67% ETA 0:18:28
 5.4GiB 0:39:00 [2.97MiB/s] [======================>           ] 68% ETA 0:17:48
5.49GiB 0:39:30 [3.03MiB/s] [======================>           ] 69% ETA 0:17:05
5.57GiB 0:40:00 [2.72MiB/s] [======================>           ] 70% ETA 0:16:29
5.66GiB 0:40:30 [2.96MiB/s] [=======================>          ] 71% ETA 0:15:48
5.74GiB 0:41:00 [2.97MiB/s] [=======================>          ] 73% ETA 0:15:09
5.83GiB 0:41:30 [2.93MiB/s] [========================>         ] 74% ETA 0:14:30
5.92GiB 0:42:00 [3.08MiB/s] [========================>         ] 75% ETA 0:13:49
6.01GiB 0:42:30 [3.17MiB/s] [========================>         ] 76% ETA 0:13:06
6.11GiB 0:43:00 [3.37MiB/s] [=========================>        ] 77% ETA 0:12:21
6.22GiB 0:43:30 [3.49MiB/s] [=========================>        ] 78% ETA 0:11:34
6.31GiB 0:44:00 [3.15MiB/s] [==========================>       ] 80% ETA 0:10:53
6.41GiB 0:44:30 [3.54MiB/s] [==========================>       ] 81% ETA 0:10:07
6.52GiB 0:45:00 [3.59MiB/s] [==========================>       ] 82% ETA 0:09:20
6.62GiB 0:45:30 [3.54MiB/s] [===========================>      ] 84% ETA 0:08:35
6.72GiB 0:46:00 [3.37MiB/s] [===========================>      ] 85% ETA 0:07:52
6.81GiB 0:46:30 [   3MiB/s] [============================>     ] 86% ETA 0:07:15
6.82GiB 0:50:50 [72.3KiB/s] [============================>     ] 86% ETA 0:07:46
6.83GiB 0:50:50 [ 334KiB/s] [============================>     ] 86% ETA 0:07:46
6.86GiB 0:51:21 [1.32MiB/s] [============================>     ] 87% ETA 0:07:30
6.87GiB 0:53:09 [  56KiB/s] [============================>     ] 87% ETA 0:07:43
6.87GiB 0:53:09 [  56KiB/s] [============================>     ] 87% ETA 0:07:43
6.94GiB 0:53:39 [2.38MiB/s] [============================>     ] 88% ETA 0:07:10
7.01GiB 0:54:09 [2.51MiB/s] [=============================>    ] 89% ETA 0:06:35
7.09GiB 0:54:39 [2.52MiB/s] [=============================>    ] 90% ETA 0:06:00
7.16GiB 0:55:09 [2.39MiB/s] [=============================>    ] 90% ETA 0:05:28
7.23GiB 0:55:39 [2.42MiB/s] [=============================>    ] 91% ETA 0:04:55
 7.3GiB 0:56:09 [2.48MiB/s] [==============================>   ] 92% ETA 0:04:21
7.37GiB 0:56:39 [ 2.4MiB/s] [==============================>   ] 93% ETA 0:03:49
7.44GiB 0:57:09 [2.39MiB/s] [==============================>   ] 94% ETA 0:03:16
7.51GiB 0:57:39 [2.44MiB/s] [===============================>  ] 95% ETA 0:02:43
7.58GiB 0:58:09 [2.42MiB/s] [===============================>  ] 96% ETA 0:02:10
7.67GiB 0:58:39 [2.85MiB/s] [===============================>  ] 97% ETA 0:01:31
7.75GiB 0:59:09 [2.83MiB/s] [================================> ] 98% ETA 0:00:53
7.84GiB 0:59:39 [2.88MiB/s] [================================> ] 99% ETA 0:00:15
7.87GiB 0:59:59 [2.24MiB/s] [================================>] 100%            
Set umask to 002
Cloning git repository origin/checkout-test-refactor
Updating permissions
Installing composer dependencies
Installing javascript dependencies
yarn install v1.3.2
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > react-paginate@5.0.0" has incorrect peer dependency "react@^16.0.0".
[4/4] Rebuilding all packages...
success Saved lockfile.
Done in 24.27s.
Compiling assets
[00:14:28] Using gulpfile ~/staging-sites/checkout-test-refactor/gulpfile.js
[00:14:28] Starting 'build-production'...
[00:14:28] Starting 'scss'...
[00:14:28] Starting 'babel'...
[00:14:28] Starting 'browserify-production'...
[00:14:28] Finished 'build-production' after 58 ms
[00:14:30] Finished 'babel' after 1.6 s
[00:14:59] Finished 'browserify-production' after 31 s
[00:15:00] Finished 'scss' after 32 s
[00:15:00] Starting 'useref'...
[00:15:59] Finished 'useref' after 59 s
Updating composer permissions
Fixing Directories
Configuring secrets
Migrating
Nothing to do